netdev - Re: [PATCH 04/39] wimax: internal API for the kernel space WiMAX stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200812021807.38335.inaky@linux.intel.com>
Date:	Tue, 2 Dec 2008 18:07:38 -0800
From:	Inaky Perez-Gonzalez <inaky@...ux.intel.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 04/39] wimax: internal API for the kernel space WiMAX stack

On Thursday 27 November 2008, Johannes Berg wrote:
> On Wed, 2008-11-26 at 15:07 -0800, Inaky Perez-Gonzalez wrote:


> > +static inline __must_check
> > +int wimax_dev_is_ready(struct wimax_dev *wimax_dev)
> > +{
> > +	if (wimax_dev->state == __WIMAX_ST_NULL)
> > +		return -EINVAL;	/* Device is not even registered! */
> > +	if (wimax_dev->state == WIMAX_ST_DOWN)
> > +		return -ENOMEDIUM;
>
> ENOLINK seems more appropriate?

Well, this means there is no medium on which to try to establish a
link. It doesn't really matter.

Is it used mainly for storage applications?

> > +/*
> > + * The concept of a pipe -- we encapsulate it because we want to
> > + * detach the usage of it from the implementation, and thus it serves
> > + * just as a handle.
>
> Might help to explain just what the concept is :)

Yes, that required some documentation fixes; added, thanks.


-- 
Inaky

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html