netdev - Re: [PATCH] can: Fix CAN_(EFF|RTR)_FLAG handling in can

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081203.155354.206786507.davem@davemloft.net>
Date:	Wed, 03 Dec 2008 15:53:54 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	oliver@...tkopp.net
Cc:	greg@...ah.com, kurt.van.dijck@....be, netdev@...r.kernel.org,
	stable@...nel.org
Subject: Re: [PATCH] can: Fix CAN_(EFF|RTR)_FLAG handling in can_filter

From: Oliver Hartkopp <oliver@...tkopp.net>
Date: Mon, 01 Dec 2008 17:15:42 +0100

> can: Fix CAN_(EFF|RTR)_FLAG handling in can_filter
> 
> Due to a wrong safety check in af_can.c it was not possible to filter
> for SFF frames with a specific CAN identifier without getting the
> same selected CAN identifier from a received EFF frame also.
> 
> This fix has a minimum (but user visible) impact on the CAN filter
> API and therefore the CAN version is set to a new date.
> 
> Indeed the 'old' API is still working as-is. But when now setting
> CAN_(EFF|RTR)_FLAG in can_filter.can_mask you might get less traffic
> than before - but still the stuff that you expected to get for your
> defined filter ...
> 
> Thanks to Kurt Van Dijck for pointing at this issue and for the review.
> 
> Signed-Off-by: Oliver Hartkopp <oliver@...tkopp.net>
> Acked-by: Kurt Van Dijck <kurt.van.dijck@....be>

Applied to net-2.6

But you are totally kidding yourself if you think that bumping
that completely stupid date string has any meaning at all for
userspace.

You're either keeping to the API you're exporting to userspace
or you're not.  And using a date string which userland has to
test is just a cop-out for not breaking userspace interfaces.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html