netdev - Re: [PATCH next 1/2]e1000: e1000_adapter->polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9929d2390812031559q740f16bfhc1626b5d955ad737@mail.gmail.com>
Date:	Wed, 3 Dec 2008 15:59:49 -0800
From:	"Jeff Kirsher" <jeffrey.t.kirsher@...el.com>
To:	"Wang Chen" <wangchen@...fujitsu.com>
Cc:	"David Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	"Emil Tantilov" <emil.s.tantilov@...el.com>
Subject: Re: [PATCH next 1/2]e1000: e1000_adapter->polling_netdev is useless

On Wed, Dec 3, 2008 at 4:57 AM, Wang Chen <wangchen@...fujitsu.com> wrote:
> David Miller said the following on 2008-12-3 7:06:
>> From: Wang Chen <wangchen@...fujitsu.com>
>> Date: Tue, 02 Dec 2008 21:33:09 +0800
>>
>>> e1000_adapter->polling_netdev is not actually used after allocated.
>>> So, my question is that is it useless?
>>
>> It's probably a leftover from before we added support for
>> multiqueue NAPI.
>>
>> Intel folks can probably confirm.
>
> Commit bea3348eef27e6044b6161fd04c3152215f96411
> "[NET]: Make NAPI polling independent of struct net_device objects."
> made NAPI polling to be independent of net_device.
> So e1000_adapter->polling_netdev is no longer used.
> Kill it.
>
> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>
> ---
>  drivers/net/e1000/e1000.h      |    1 -
>  drivers/net/e1000/e1000_main.c |   27 +--------------------------
>  2 files changed, 1 insertions(+), 27 deletions(-)
>

Testing looks good.
Tested-by: Emil Tantilov <emil.s.tantilov@...el.com>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html