netdev - Re: [PATCH next] sgi-xp: Kill directly reference of netdev->priv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081204.151258.68139939.davem@davemloft.net>
Date:	Thu, 04 Dec 2008 15:12:58 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ilpo.jarvinen@...sinki.fi
Cc:	wangchen@...fujitsu.com, netdev@...r.kernel.org
Subject: Re: [PATCH next] sgi-xp: Kill directly reference of netdev->priv

From: "Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Thu, 4 Dec 2008 15:41:15 +0200 (EET)

> On Thu, 4 Dec 2008, Wang Chen wrote:
> 
> > Simply replace netdev->priv with netdev_priv().
> > 
> > Not do compile test, because no IA64 or x86_64 box.
> > 
> > Signed-off-by: Wang Chen <wangchen@...fujitsu.com>
> > ---
> >  drivers/misc/sgi-xp/xpnet.c |    9 +++++----
> >  1 files changed, 5 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/misc/sgi-xp/xpnet.c b/drivers/misc/sgi-xp/xpnet.c
> > index 71513b3..9e5233a 100644
> > --- a/drivers/misc/sgi-xp/xpnet.c
> > +++ b/drivers/misc/sgi-xp/xpnet.c
> > @@ -154,7 +154,7 @@ xpnet_receive(short partid, int channel, struct xpnet_message *msg)
> >  	void *dst;
> >  	enum xp_retval ret;
> >  	struct xpnet_dev_private *priv =
> > -	    (struct xpnet_dev_private *)xpnet_device->priv;
> > +	    (struct xpnet_dev_private *)netdev_priv(xpnet_device);
> 
> netdev_priv returns void, so these casts seem unnecessary here & other 
> places belwo (which I cut)...

I took care of fixing this up when applying Wang's patch.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html