netdev - Re: [PATCH] tcp: make urg+gso work for real this time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081203.212542.139360072.davem@davemloft.net>
Date:	Wed, 03 Dec 2008 21:25:42 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ilpo.jarvinen@...sinki.fi
Cc:	ptesarik@...e.cz, netdev@...r.kernel.org
Subject: Re: [PATCH] tcp: make urg+gso work for real this time

From: "Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Wed, 3 Dec 2008 20:31:09 +0200 (EET)

> On Wed, 3 Dec 2008, Petr Tesarik wrote:
> 
> > Ilpo Järvinen píse v St 03. 12. 2008 v 13:22 +0200:
> > Yes, re-fragmenting the packet here is probably the best way to go. But
> > repeating the same condition on multiple places is not so nice. What
> > about this little improvement?
> 
> Yeah, this too will work... Though not of too much significance since
> I've already most of unification of those two functions in a local
> queue awaiting testing, polish up and submit to net-next.
> 
> When sending an updated version davem prefers to have full changelog in it 
> btw, it saves some work for him.
> 
> > (I didn't roll the revert of 33cf71cee1 into it, as it makes the actual
> > change less obvious. I think there are better ways of doing a revert in
> > git.)
> 
> Whatever, I've no strong opinion either way though it's just broken with 
> and without the revert anyway, the full thing is needed to actually fix 
> it.

I've applied Ilpo's version of the fix patch, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html