netdev - Re: [PATCH next 1/2]e1000: e1000_adapter->polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081203.220739.254257242.davem@davemloft.net>
Date:	Wed, 03 Dec 2008 22:07:39 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	wangchen@...fujitsu.com
Cc:	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org
Subject: Re: [PATCH next 1/2]e1000: e1000_adapter->polling_netdev is useless

From: Wang Chen <wangchen@...fujitsu.com>
Date: Wed, 03 Dec 2008 20:57:41 +0800

> David Miller said the following on 2008-12-3 7:06:
> > From: Wang Chen <wangchen@...fujitsu.com>
> > Date: Tue, 02 Dec 2008 21:33:09 +0800
> > 
> >> e1000_adapter->polling_netdev is not actually used after allocated.
> >> So, my question is that is it useless?
> > 
> > It's probably a leftover from before we added support for
> > multiqueue NAPI.
> > 
> > Intel folks can probably confirm.
> 
> Commit bea3348eef27e6044b6161fd04c3152215f96411
> "[NET]: Make NAPI polling independent of struct net_device objects."
> made NAPI polling to be independent of net_device.
> So e1000_adapter->polling_netdev is no longer used.
> Kill it.
> 
> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>

Applied, thanks Wang.

Jeff, I know you said you are regression-testing this.  If you
find some problem we can revert or add a fix.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html