netdev - Re: [E1000-devel] networking probs in next-20081203

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1k5afqcxx.fsf@frodo.ebiederm.org>
Date:	Thu, 04 Dec 2008 23:49:14 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	James Morris <jmorris@...ei.org>
Cc:	Stephen Smalley <sds@...ho.nsa.gov>,
	David Miller <davem@...emloft.net>, adobriyan@...il.com,
	auke-jan.h.kok@...el.com, akpm@...ux-foundation.org,
	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	eparis@...isplace.org
Subject: Re: [E1000-devel] networking probs in next-20081203

James Morris <jmorris@...ei.org> writes:

> On Thu, 4 Dec 2008, Eric W. Biederman wrote:
>
>> Which piece of selinux magic did I miss?
>
> The problem is that SELinux doesn't know anything about the new filesystem 
> type, and specifically, to treat it like procfs.  There are a couple 
> workarounds we can try to prevent this specific problem from cropping up 
> again.

The thing is I believe I changed the internal filesystem test to
strncmp(fstype, "proc", 4);

Which should match both proc and proc/net

And likewise I thought I provided the same name by for the magic label
lookup by name.

>> In particular can you tell if this was a code bug or a logic bug?
>
> I wouldn't say it was a bug, more a consequence of necessarily imperfect 
> encapsulation of the security code via LSM.  It's just something we have to 
> keep an eye out for.

Yes.  Was the piece I missed in the LSM rules loaded from user space?

Eric
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html