netdev - Re: [PATCH 2.6.27] tcp_vegas ssthresh bug fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081204.171746.256513842.davem@davemloft.net>
Date:	Thu, 04 Dec 2008 17:17:46 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	Doug.Leith@...m.ie
Cc:	netdev@...r.kernel.org, shemminger@...tta.com
Subject: Re: [PATCH 2.6.27] tcp_vegas ssthresh bug fix

From: Douglas Leith <Doug.Leith@...m.ie>
Date: Fri, 05 Dec 2008 00:11:05 +0000

> This patch fixes a bug in tcp_vegas.c.  At the moment this code leaves ssthresh untouched.  However, this means that the vegas congestion control algorithm is effectively unable to reduce cwnd below the ssthresh value (if the vegas update lowers the cwnd below ssthresh, then slow start is activated to raise it back up).   One example where this matters is when during slow start cwnd overshoots the link capacity and a flow then exits slow start with ssthresh set to a value above where congestion avoidance would like to adjust it.
> 
> Signed-off-by:  Doug Leith <doug.leith@...m.ie>

Nevermind, I see that you used an attachment, so I
applied this, but:

> --- net/ipv4/tcp_vegas.c.orig   2008-12-04 23:51:19.000000000 +0000
> +++ net/ipv4/tcp_vegas.c        2008-12-05 00:00:42.000000000 +0000

You really need to -p1 root your patches.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html