| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20081205.223754.166106378.davem@davemloft.net> Date: Fri, 05 Dec 2008 22:37:54 -0800 (PST) From: David Miller <davem@...emloft.net> To: inaky@...ux.intel.com Cc: netdev@...r.kernel.org, wimax@...uxwimax.org, greg@...ah.com Subject: Re: [PATCH 02/40] wimax: declarations for the in-kernel WiMAX API From: Inaky Perez-Gonzalez <inaky@...ux.intel.com> Date: Fri, 5 Dec 2008 10:54:55 -0800 > Declares the main data types and calls for the drivers to integrate > into the WiMAX stack. Provides usage documentation. > > Signed-off-by: Inaky Perez-Gonzalez <inaky@...ux.intel.com> This does: +#include <linux/wimax.h> which doesn't even exist yet. I understand what you're trying to do, chop things up into manageable pieces. But this is taking it way too far. It's totally impossible to review this patch on it's own, because none of the necessary context exists at this point in the patch series. I read this and wanted to know what enum wimax_st was, but that is impossible to find because of this problem. 40 patches is, a lot, and I've now gone through this both in my inbox and in my patch queue at patchwork.ozlabs.org 3 times. You need to compact this a lot more if you want people to review it without losing an entire day of their lives doing so. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists