netdev - Re: [PATCH 02/29] wimax: headers for kernel API and user space interaction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1228766734.22164.127.camel@johannes.berg>
Date:	Mon, 08 Dec 2008 21:05:34 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Inaky Perez-Gonzalez <inaky@...ux.intel.com>
Cc:	netdev@...r.kernel.org, wimax@...uxwimax.org, greg@...ah.com
Subject: Re: [PATCH 02/29] wimax: headers for kernel API and user space
	interaction

On Mon, 2008-12-08 at 11:09 -0800, Inaky Perez-Gonzalez wrote:

> +/*
> + * Generic NetLink operations
> + *
> + * Most of these map to an API call; _OP_ stands for operation, _RP_
> + * for reply and _RE_ for report (aka: signal).
> + */
> +enum {
> +	WIMAX_GNL_OP_MSG_FROM_USER,	/* User to kernel message */
> +	WIMAX_GNL_OP_MSG_TO_USER,	/* Kernel to user message */

Since you're going to do these iwpriv-style things anyway no matter what
I say :) can we at least get it to use netlink attributes *within*
these? In i2400m you define a new protocol that pretty much looks
identical to netlink attributes, but just a bit different:

> + * This is the control protocol used by the host to control the i2400m
> + * device (scan, connect, disconnect...). This is sent to / received
> + * as control frames. These frames consist of a header and zero or
> + * more TLVs with information. We call each control frame a "message".

Or isn't that what is contained in the WIMAX_GNL_MSG_DATA attribute? You
can nest netlink attributes, that would already make it a whole lot more
regular, rather than defining your own sub-protocol.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)