netdev - Re: [PATCH 1/7] dccp: Integration of dynamic feature activation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081208.011535.209538564.davem@davemloft.net>
Date:	Mon, 08 Dec 2008 01:15:35 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	gerrit@....abdn.ac.uk
Cc:	dccp@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/7] dccp: Integration of dynamic feature activation -
 part 1 (socket setup)

From: Gerrit Renker <gerrit@....abdn.ac.uk>
Date: Sat,  6 Dec 2008 17:40:51 +0100

> This first patch out of three replaces the hardcoded default settings with
> initialisation code for the dynamic feature negotiation.
> 
> The patch also ensures that the client feature-negotiation queue is flushed
> only when entering the OPEN state.
> 
> Since confirmed Change options are removed as soon as they are confirmed
> (in the DCCP-Response), this ensures that Confirm options are retransmitted.
> 
> Note on retransmitting Confirm options:
> ---------------------------------------
> Implementation experience showed that it is necessary to retransmit Confirm
> options. Thanks to Leandro Melo de Sales who reported a bug in an earlier
> revision of the patch set, resulting from not retransmitting these options.
> 
> As long as the client is in PARTOPEN, it needs to retransmit the Confirm
> options for the Change options received on the DCCP-Response from the server.
> 
> Otherwise, if the packet containing the Confirm options gets dropped in the
> network, the connection aborts due to undefined feature negotiation state.
> 
> 
> Signed-off-by: Gerrit Renker <gerrit@....abdn.ac.uk>
> Acked-by: Ian McDonald <ian.mcdonald@...di.co.nz>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html