netdev - Re: [PATCH] PCIe ASPM causes machine (HP Compaq 6735s) to sometimes freeze hard at boot at PCI initialization time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1228699962.13024.2.camel@sli10-desk.sh.intel.com>
Date:	Mon, 08 Dec 2008 09:32:42 +0800
From:	Shaohua Li <shaohua.li@...el.com>
To:	Matthew Garrett <mjg59@...f.ucam.org>
Cc:	Thomas Renninger <trenn@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"jbarnes@...tuousgeek.org" <jbarnes@...tuousgeek.org>,
	Rafael Wysocki <rwysocki@...e.de>,
	"shemminger@...ux-foundation.org" <shemminger@...ux-foundation.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Stable@...nel.org" <Stable@...nel.org>
Subject: Re: [PATCH] PCIe ASPM causes machine (HP Compaq 6735s) to
	sometimes freeze hard at boot at PCI initialization time

On Sat, 2008-12-06 at 02:21 +0800, Matthew Garrett wrote:
> On Fri, Dec 05, 2008 at 02:07:13PM +0100, Thomas Renninger wrote:
> 
> > PCIE: Break out of endless loop waiting for PCI config bits to switch
> > 
> > Makes a Compaq 6735s boot reliably again which hang in the loop
> > on some boots.
> 
> Which device does it get stuck on?
> 
> > +	if (loop_count == 100) 
> > +		dev_printk (KERN_WARNING, &pdev->dev, "Could not configure ASPM\n");
> 
> "ASPM: Could not configure common clock\n"? ASPM should still work, 
> though with higher latency. It probably also needs to revert the 
> configuration changes.
Yep, Just undo the pci config writes of pcie_aspm_configure_common_clock should be fine to me.
Maybe an expiration time is ok here.
Does the device work after this?

Thanks,
Shaohua

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html