netdev - Re: [PATCH 3/3] hso modem port detection fix patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081208.025447.99306942.davem@davemloft.net>
Date:	Mon, 08 Dec 2008 02:54:47 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	D.Barow@...ion.com
Cc:	linux-usb@...r.kernel.org, netdev@...r.kernel.org,
	alan@...rguk.ukuu.org.uk
Subject: Re: [PATCH 3/3] hso modem port detection fix patch

From: Denis Joseph Barrow <D.Barow@...ion.com>
Date: Mon, 08 Dec 2008 11:44:57 +0100

Again, please CC: Alan for changes that might even remotely
be TTY layer related and thus he'd be interested in reviewing.

Thanks.

> This patch will clash with the previously posted.
> [PATCH 1/3] hso modem signals patch fix & should only
> be applied if the hso modem signals patch fix patch
> is not applied.
> 
> Fixed incorrect check for the modem port,
> Signed-off-by: Denis Joseph Barrow <D.Barow@...ion.com>
> ---
> Index: netdev-2.6/drivers/net/usb/hso.c
> ===================================================================
> --- netdev-2.6.orig/drivers/net/usb/hso.c	2008-12-08 11:29:03.000000000 +0100
> +++ netdev-2.6/drivers/net/usb/hso.c	2008-12-08 11:30:00.000000000 +0100
> @@ -2343,7 +2343,7 @@
>  	serial->parent = hso_dev;
>  	hso_dev->port_data.dev_serial = serial;
>  
> -	if (port & HSO_PORT_MODEM)
> +	if ((port & HSO_PORT_MASK) == HSO_PORT_MODEM)
>  		num_urbs = 2;
>  	else
>  		num_urbs = 1;
> 
> 
> 
> -- 
> best regards,
> D.J. Barrow
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html