netdev - Re: [Patch] Micrel KS8695 intergrated ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081209.010529.57138453.davem@davemloft.net>
Date:	Tue, 09 Dec 2008 01:05:29 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	hch@...radead.org
Cc:	dsilvers@...tec.co.uk, netdev@...r.kernel.org
Subject: Re: [Patch] Micrel KS8695 intergrated ethernet driver

From: Christoph Hellwig <hch@...radead.org>
Date: Tue, 9 Dec 2008 03:57:39 -0500

> On Mon, Dec 08, 2008 at 11:05:18AM +0000, Daniel Silverstone wrote:
> > > > +                       mapping = dma_map_single(ksp->dev, skb->data,
> > > > +                                                MAX_RXBUF_SIZE,
> > > > +                                                DMA_FROM_DEVICE);
> > > I take it that dma_map_single() can never fail on ARM?
> > 
> > No it can't. It essentially boils down to some pointer arithmetic on
> > this platform.
> 
> You should check for errors anyway.  The driver might be ported to an
> architecture where it can fail (e.g. the SOC block gets reused), ARM
> variants may come up where it can fail, or people might use the driver
> as an example for their own new driver.

Agreed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html