netdev - Re: [PATCH] net: Kill directly reference of netdev->priv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <493DDDA2.9080100@cn.fujitsu.com>
Date:	Tue, 09 Dec 2008 10:53:22 +0800
From:	Wei Yongjun <yjwei@...fujitsu.com>
To:	Jianjun Kong <jianjun@...ux.org>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: Kill directly reference of netdev->priv

Jianjun Kong wrote:
> another new patch for net-next-2.6
> ---
>
> >From fbd6be20695810f32aa58a5cd889f959d87a019f Mon Sep 17 00:00:00 2001
> From: Jianjun Kong <jianjun@...ux.org>
> Date: Tue, 9 Dec 2008 09:23:54 +0800
> Subject: [PATCH] net: Kill directly reference of netdev->priv
>
> drivers/net/wireless/ray_cs.c:
> Replace "(struct net_device *)link->priv" with "netdev_priv((struct net_device *)link)"
>   

You had tested this patch? Do you think your patch is correct? Stop do 
stupid things like this. This only make youself unbelievable.

> Signed-off-by: Jianjun Kong <jianjun@...ux.org>
> ---
>  drivers/net/wireless/ray_cs.c |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c
> index 81b71f0..828aa47 100644
> --- a/drivers/net/wireless/ray_cs.c
> +++ b/drivers/net/wireless/ray_cs.c
> @@ -412,7 +412,7 @@ static int ray_config(struct pcmcia_device *link)
>      int i;
>      win_req_t req;
>      memreq_t mem;
> -    struct net_device *dev = (struct net_device *)link->priv;
> +    struct net_device *dev = netdev_priv((struct net_device *)link);
>      ray_dev_t *local = netdev_priv(dev);
>  
>      DEBUG(1, "ray_config(0x%p)\n", link);
> @@ -784,7 +784,7 @@ static void join_net(u_long data)
>  =============================================================================*/
>  static void ray_release(struct pcmcia_device *link)
>  {
> -    struct net_device *dev = link->priv; 
> +    struct net_device *dev = netdev_priv((struct net_device *)link);
>      ray_dev_t *local = netdev_priv(dev);
>      int i;
>      
> @@ -807,7 +807,7 @@ static void ray_release(struct pcmcia_device *link)
>  
>  static int ray_suspend(struct pcmcia_device *link)
>  {
> -	struct net_device *dev = link->priv;
> +	struct net_device *dev = netdev_priv((struct net_device *)link);
>  
>  	if (link->open)
>  		netif_device_detach(dev);
> @@ -817,7 +817,7 @@ static int ray_suspend(struct pcmcia_device *link)
>  
>  static int ray_resume(struct pcmcia_device *link)
>  {
> -	struct net_device *dev = link->priv;
> +	struct net_device *dev = netdev_priv((struct net_device *)link);
>  
>  	if (link->open) {
>  		ray_reset(dev);
> @@ -2505,7 +2505,7 @@ static void associate(ray_dev_t *local)
>  {
>      struct ccs __iomem *pccs;
>      struct pcmcia_device *link = local->finder;
> -    struct net_device *dev = link->priv;
> +    struct net_device *dev = netdev_priv((struct net_device *)link);
>      int ccsindex;
>      if (!(pcmcia_dev_present(link))) {
>          DEBUG(2,"ray_cs associate - device not present\n");
> @@ -2597,7 +2597,7 @@ static int ray_cs_proc_show(struct seq_file *m, void *v)
>      link = this_device;
>      if (!link)
>      	return 0;
> -    dev = (struct net_device *)link->priv;
> +    dev = netdev_priv((struct net_device *)link);
>      if (!dev)
>      	return 0;
>      local = netdev_priv(dev);
>   

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html