netdev - Re: [NET-NEXT PATCH] ixgbe: Implement PCIe AER support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.WNT.4.64.0812082307290.696@ppwaskie-MOBL2.amr.corp.intel.com>
Date:	Mon, 8 Dec 2008 23:13:31 -0800 (Pacific Standard Time)
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	David Miller <davem@...emloft.net>
cc:	"shemminger@...tta.com" <shemminger@...tta.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"jeff@...zik.org" <jeff@...zik.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: [NET-NEXT PATCH] ixgbe: Implement PCIe AER support

On Mon, 1 Dec 2008, David Miller wrote:

> From: Stephen Hemminger <shemminger@...tta.com>
> Date: Mon, 1 Dec 2008 17:47:54 -0800
> 
> > pci_enable_pcie_error_reporting should be checking for pci_read/pci_write
> > config errors and does not.
> >
> > Your driver should be checking for pci_enable_pcie_error_reporting failing.
> 
> Agreed.

I've finally been able to get back to this.  I've looked at any other 
prior use of the PCIe AER routines, and the only driver using it to date 
is the QLogic QLA2xxx driver in SCSI-land.  I've also looked at the return 
codes, with and without Stephen's recent AER patch, and there's not much 
the driver can do.  If it's catching the errors, the best I can do is 
print an error message, then continue along.

I've put that patch together, and will have it sent along shortly.  If 
there's something additional I'm missing here, please let me know.

Cheers,
-PJ
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html