netdev - Re: [PATCH] simnet: convert to net_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081210.152524.226506156.davem@davemloft.net>
Date:	Wed, 10 Dec 2008 15:25:24 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	a.beregalov@...il.com
Cc:	adobriyan@...il.com, linux-next@...r.kernel.org,
	netdev@...r.kernel.org, linux-ia64@...r.kernel.org
Subject: Re: [PATCH] simnet: convert to net_device_ops

From: "Alexander Beregalov" <a.beregalov@...il.com>
Date: Wed, 10 Dec 2008 14:21:46 +0300

> 2008/12/10 David Miller <davem@...emloft.net>:
> > From: Alexey Dobriyan <adobriyan@...il.com>
> > Date: Tue, 9 Dec 2008 18:08:27 +0300
> >
> >> On Tue, Dec 09, 2008 at 05:11:17PM +0300, Alexander Beregalov wrote:
> >> >   CC      arch/ia64/hp/sim/simeth.o
> >> > arch/ia64/hp/sim/simeth.c: In function 'simeth_probe1':
> >> > arch/ia64/hp/sim/simeth.c:212: error: 'struct net_device' has no member named 'open'
> >>
> >> [PATCH] simeth: convert to net_device_ops
> >>
> >> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> >
> > This doesn't explain the build failure.
> >
> > Using ->open() and friends should work perfectly fine for drivers not
> > yet converted to netdev_ops.  The code protected by COMPAT_NET_DEV_OPS
> > provides this, and we force that Kconfig option to always be on.
> >
> > I don't want to add this patch and just shrug off this build failure.
> > If this build failures, we should be seeing 200 other drivers not
> > build too.
> >
> > I suspect something is messed up with this person's kernel config
> > or similar.
> >
> 
> Thanks for explanation.
> Is it better?

Good fix, except that your email client corrupted the patch
by turning tab characters into spaces.

I fixed this up and applied your patch.  But please next
time provide a proper Signed-off-by line too.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html