netdev - Re: [PATCH 01/11] benet: header and init functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081209.224428.261629001.davem@davemloft.net>
Date:	Tue, 09 Dec 2008 22:44:28 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sathyap@...verengines.com
Cc:	netdev@...r.kernel.org, jgarzik@...ox.com, jeff@...zik.org,
	subbus@...verengines.com
Subject: Re: [PATCH 01/11] benet: header and init functions

From: Sathya Perla <sathyap@...verengines.com>
Date: Tue, 09 Dec 2008 19:49:44 +0530

> +	pnob = netdev->priv;

netdev->priv should never be accessed directly, use
netdev_priv() always

netdev->priv has even been removed in the net-next-2.6
tree so we don't want any new references sneaking into
the tree as this will cause build failures.

> +	struct be_net_object *pnob = (struct be_net_object *)netdev->priv;
 ...
> +	struct be_net_object *pnob = (struct be_net_object *)netdev->priv;

And when you convert these cases, remove the casts.

They are pointless since netdev_priv() (and netdev->priv) are void
pointers.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html