netdev - Re: [PATCH 08/11] benet: hardware host interface header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081209.224904.181841905.davem@davemloft.net>
Date:	Tue, 09 Dec 2008 22:49:04 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sathyap@...verengines.com
Cc:	netdev@...r.kernel.org, jgarzik@...ox.com, subbus@...verengines.com
Subject: Re: [PATCH 08/11] benet: hardware host interface header files

From: Sathya Perla <sathyap@...verengines.com>
Date: Tue, 09 Dec 2008 19:50:49 +0530

> +} __packed;

Packed is pointless for datastructures containing only
8-bit integers.

> +	u8 interrupt32;	/* DWORD 0 */
> +	u8 interrupt33;	/* DWORD 0 */
> +	u8 interrupt34;	/* DWORD 0 */
> +	u8 interrupt35;	/* DWORD 0 */
> +	u8 interrupt36;	/* DWORD 0 */
> +	u8 interrupt37;	/* DWORD 0 */
> +	u8 interrupt38;	/* DWORD 0 */
> +	u8 interrupt39;	/* DWORD 0 */
> +	u8 interrupt40;	/* DWORD 0 */
> +	u8 interrupt41;	/* DWORD 0 */
> +	u8 interrupt42;	/* DWORD 0 */
> +	u8 interrupt43;	/* DWORD 0 */

Why do all of these comments say "DWORD 0"?  It can't
mean that the member is at offset "DWORD 0", there
are too many of these bytes to stay in DWORD 0.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html