netdev - Re: [RFC][PATCH 3/3]ipv6:fix the outgoing interface selection order in udpv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <493F8EBA.7070907@cn.fujitsu.com>
Date:	Wed, 10 Dec 2008 17:41:14 +0800
From:	Yang Hongyang <yanghy@...fujitsu.com>
To:	David Miller <davem@...emloft.net>
CC:	remi.denis-courmont@...ia.com, netdev@...r.kernel.org
Subject: Re: [RFC][PATCH 3/3]ipv6:fix the outgoing interface selection order
 in udpv6_sendmsg()

David Miller wrote:
> From: Yang Hongyang <yanghy@...fujitsu.com>
> Date: Wed, 10 Dec 2008 14:38:25 +0800
> 
...snip...
>>>>
>>> Hum..can we just ignore the sync of the sticky option and the SO_BINDTODEVICE,
>>> when send a message,first check sk_bound_dev_if,If it is specified,use it,otherwise
>>> use sticky option?This was what i ment. and in my patch ,the outgoing interface 
>>> specified by sticky options will be overrided by the interface specified by 
>>> SO_BINDTODEVICE.
>> If this is the solution, i'll post a updated patch.
> 
> Please do, this sounds like the correct approach.
> 

Thanks for your comment,here is the updated patch:

1.When no interface is specified in an IPV6_PKTINFO ancillary data
  item, the interface specified in an IPV6_PKTINFO sticky optionis 
  is used.

RFC3542:
6.7.  Summary of Outgoing Interface Selection

   This document and [RFC-3493] specify various methods that affect the
   selection of the packet's outgoing interface.  This subsection
   summarizes the ordering among those in order to ensure deterministic
   behavior.

   For a given outgoing packet on a given socket, the outgoing interface
   is determined in the following order:

   1. if an interface is specified in an IPV6_PKTINFO ancillary data
      item, the interface is used.

   2. otherwise, if an interface is specified in an IPV6_PKTINFO sticky
      option, the interface is used.

Signed-off-by: Yang Hongyang<yanghy@...fujitsu.com>

---
 net/ipv6/udp.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c
index 8b48512..6b06421 100644
--- a/net/ipv6/udp.c
+++ b/net/ipv6/udp.c
@@ -763,6 +763,9 @@ do_udp_sendmsg:
 	if (!fl.oif)
 		fl.oif = sk->sk_bound_dev_if;
 
+	if (!fl.oif)
+		fl.oif = np->sticky_pktinfo.ipi6_ifindex;
+
 	if (msg->msg_controllen) {
 		opt = &opt_space;
 		memset(opt, 0, sizeof(struct ipv6_txoptions));
-- 
1.6.0.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html