netdev - Re: [PATCH net] Phonet: ensure GPRS device does not go away during TX work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200812111011.17891.remi.denis-courmont@nokia.com>
Date:	Thu, 11 Dec 2008 10:11:17 +0200
From:	"Rémi Denis-Courmont" 
	<remi.denis-courmont@...ia.com>
To:	"ext David Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net] Phonet: ensure GPRS device does not go away during TX work

On Thursday 11 December 2008 01:28:45 ext David Miller, you wrote:
> From: Rémi Denis-Courmont <remi.denis-courmont@...ia.com>
> Date: Wed, 10 Dec 2008 15:15:28 +0200
>
> > We need to hold the device while TX work is pending, as work is flushed
> > only after the network device is unregistered.
> >
> > Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@...ia.com>
>
> This seems unnecessary.
>
> If you simply create proper ->open and ->stop methods for the GPRS net
> device you can purge the TX queue in ->stop() and avoid this
> refcounting business.

Ok. Can I assume that scheduled work will be flushed sometime between ->stop 
and ->destructor then?

-- 
Rémi Denis-Courmont
Maemo Software, Nokia Devices R&D
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html