lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Dec 2008 21:31:08 -0800 (PST) From: David Miller <davem@...emloft.net> To: bhutchings@...arflare.com Cc: netdev@...r.kernel.org, linux-net-drivers@...arflare.com Subject: Re: [PATCH 03/33] sfc: Do not use pci_disable_device() to disable bus mastering From: Ben Hutchings <bhutchings@...arflare.com> Date: Fri, 12 Dec 2008 12:49:14 +0000 > pci_disable_device() disables many features, like MSI-X, which we > never reenable in efx_reset(). Further, calls to pci_enable_device() > and pci_disable_device() must be matched since the nesting count was > introduced. > > Signed-off-by: Ben Hutchings <bhutchings@...arflare.com> Since the PCI layer provides interfaces which do manage this setting, there is no way you should be doing this behind it's back. You know why? Because someone is going to change some of the internals of this stuff in the PIC layer and it will break your driver. Please instead submit an interface to the PCI layer maintainers that does what you want, then use it. Patch not applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists