netdev - Re: [PATCH 07/33] sfc: Clean up waits for flash/EEPROM operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081212.213359.215131885.davem@davemloft.net>
Date:	Fri, 12 Dec 2008 21:33:59 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH 07/33] sfc: Clean up waits for flash/EEPROM operations

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Fri, 12 Dec 2008 12:51:01 +0000

> Make falcon_spi_wait() ignore the write timer - it is only relevant to
> write commands, it only works for the device that contains VPD, and it
> might not be initialised properly at all.
> 
> Rename falcon_spi_fast_wait() to falcon_spi_wait_write(), reflecting
> its use, and make it wait up to 10 ms (not 1 ms) since buffered writes
> to EEPROM may take this long to complete.
> 
> Make both wait functions sleep instead of busy-waiting.
> 
> Replace wait for command completion at top of falcon_spi_cmd() with a
> single poll; no command should be running when the function starts.
> 
> Correct some comments.
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html