netdev - Re: [PATCH 25/33] sfc: Generate unique names for per-NIC workqueues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081212.220431.165056851.davem@davemloft.net>
Date:	Fri, 12 Dec 2008 22:04:31 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH 25/33] sfc: Generate unique names for per-NIC workqueues

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Fri, 12 Dec 2008 12:56:57 +0000

> @@ -1854,6 +1854,7 @@ static int efx_init_struct(struct efx_nic *efx, struct efx_nic_type *type,
>  	struct efx_channel *channel;
>  	struct efx_tx_queue *tx_queue;
>  	struct efx_rx_queue *rx_queue;
> +	char name[16];
...
> @@ -1924,7 +1925,9 @@ static int efx_init_struct(struct efx_nic *efx, struct efx_nic_type *type,
>  	efx->interrupt_mode = max(efx->type->max_interrupt_mode,
>  				  interrupt_mode);
>  
> -	efx->workqueue = create_singlethread_workqueue("sfc_work");
> +	/* Would be good to use the net_dev name, but we're too early */
> +	snprintf(name, sizeof(name), "sfc%s", pci_name(pci_dev));
> +	efx->workqueue = create_singlethread_workqueue(name);
>  	if (!efx->workqueue)

This change is buggy.

create_singlethread_workqueue() is going to reference this
name buffer on the stack for the life of the workqueue, but
once this function returns that reference will no longer
be valid.

You'll need to use kmalloc()'d memory and free it later,
or something like that.

Patch not applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html