netdev - Re: [PATCH 7/8] ethtool: Add GGRO and SGRO ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.WNT.4.64.0812141124040.13556@ppwaskie-MOBL2.amr.corp.intel.com>
Date:	Sun, 14 Dec 2008 11:36:14 -0800 (Pacific Standard Time)
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
cc:	Ben Hutchings <bhutchings@...arflare.com>,
	"David S. Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 7/8] ethtool: Add GGRO and SGRO ops

On Fri, 12 Dec 2008, Herbert Xu wrote:

> On Fri, Dec 12, 2008 at 10:35:27PM +0000, Ben Hutchings wrote:
> >
> > If I'm not mistaken, the whole point of set_flags() is to end the
> > continued expansion of struct ethtool_ops by another 2 functions for
> > every new offload feature.  The comments make it fairly clear that Jeff
> > anticipated that it might be necessary to include such checks for some
> > flags.
> 
> GRO is purely a stack feature so it doesn't need anything in
> ethtool_ops at all.

I'm confused then.  You're adding two ethtool entry points with 
ETHTOOL_GGRO and ETHTOOL_SGRO, adding the callpoints in dev_ethtool with 
set_gro and get_gro, but how do you manipulate this without adding to the 
userspace application?  Adding this functionality to the set/get_flags 
will keep the userspace app from needing a patch to support the new 
callbacks.

Cheers,
-PJ Waskiewicz
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html