netdev - Re: [RFC PATCH 02/12] net: infrastructure for hardware time stamping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1LCLNV-0001EW-CN@gondolin.me.apana.org.au>
Date:	Tue, 16 Dec 2008 08:53:25 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	patrick.ohly@...el.com (Patrick Ohly)
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	davem@...emloft.net, johnstul@...ibm.com,
	linux-api@...r.kernel.org, patrick.ohly@...el.com
Subject: Re: [RFC PATCH 02/12] net: infrastructure for hardware time stamping

Patrick Ohly <patrick.ohly@...el.com> wrote:
> @@ -305,6 +406,8 @@ struct sk_buff {
>                                ipvs_property:1,
>                                peeked:1,
>                                nf_trace:1;
> +       /* not all of the bits in optional are used */
> +       __u8                    optional;
>        __be16                  protocol;

You do reliase that this is going to grow the sk_buff by at least
4 bytes and not 1?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html