netdev - Re: [NET-NEXT PATCH 1/2] net: add error return for dcb setstate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081215.010529.26091839.davem@davemloft.net>
Date:	Mon, 15 Dec 2008 01:05:29 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, jeff@...zik.org,
	donald.c.skidmore@...el.com, eric.w.multanen@...el.com,
	peter.p.waskiewicz.jr@...el.com
Subject: Re: [NET-NEXT PATCH 1/2] net: add error return for dcb setstate

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Fri, 12 Dec 2008 01:52:21 -0800

> DCB had no way to know if setstate had failed in the driver. This
> patch enables dcb netlink code to handle the status for the DCB
> setstate interface.
> 
> Signed-off-by: Don Skidmore <donald.c.skidmore@...el.com>
> Signed-off-by: Eric W Multanen <eric.w.multanen@...el.com>
> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

How can this build if you don't also update ixgbe_dcbnl_set_state() et
al. to have a "u8" instead of a "void" return value too?

Oh I see, you send the update two patches later.

Don't do that, it breaks GIT bisect.

If you change the prototype for a method function, you must also
change all implementations of that method to match at the same time.

I've dropped both changes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html