netdev - Re: [PATCH] tcp: make urg+gso work for real this time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081217213052.GB27243@gondor.apana.org.au>
Date:	Thu, 18 Dec 2008 08:30:52 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Petr Tesarik <ptesarik@...e.cz>
Cc:	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	Ilpo J??rvinen <ilpo.jarvinen@...sinki.fi>,
	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] tcp: make urg+gso work for real this time

On Wed, Dec 17, 2008 at 05:04:48PM +0100, Petr Tesarik wrote:
>
> This is all nice, but it still does not solve those series of SIGURGs on
> the receiving side. My suggestion is to not generate a new SIGURG until
> the data for the latest one have arrived. There can be only one byte of
> urgent data, so if somebody sends more than one, it cannot be handled by
> the receiver, anyway, so that use case is broken and need not be taken
> into account.

No we need to send a SIGURG as soon as we enter urgent mode.  The
whole point of urgent mode is to inform the receiver ASAP.  As the
urgent data itself cannot be expedited due to the in-order nature
of TCP, setting the flag and sending the signal is the best we can
do.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html