netdev - Re: [PATCH v2.6.29 v2 1/5] gianfar: Fix skb allocation error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Dec 2008 15:41:09 -0600
From:	Andy Fleming <afleming@...escale.com>
To:	David Miller <davem@...emloft.net>
Cc:	jeff@...zik.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2.6.29 v2 1/5] gianfar: Fix skb allocation error


On Dec 17, 2008, at 2:22 PM, David Miller wrote:

> From: Andy Fleming <afleming@...escale.com>
> Date: Wed, 17 Dec 2008 12:52:57 -0600
>
>> We don't want to unmap the skb if we've decided to use the old one,  
>> so we only
>> unmap it if we're *not* using the old one.
>>
>> Signed-off-by: Andy Fleming <afleming@...escale.com>
>
> Andy.... look at what you're doing here.  Your patch talks about DMA
> mapping, yet the patch deals with protecting an SKB free call.
>
> Your commit message matches the original patch but not this one.
>
> In fact I fear that, in fact, there was a bug being fixed originally,
> and in fact you do need to modify where the DMA unmap occurs in this
> function, but in fixing up the patch to apply you've not gotten that
> part straight.
>
> I'm tossing these patches again.  If the commit message can't even
> match what the patch is doing, you need to take a good long look at
> these changes and then resubmit them with accurate commit messages.

Argh, I apologize.  The patch still does the same thing, but the  
dma_unmap got moved up.  The commit message got hastily composed when  
I had to reapply the patch on an older tree, and I forgot to change it  
when I fixed it.  I will review and make sure I haven't made more such  
mistakes.

Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html