netdev - Re: [PATCH v2.6.29 10/14] gianfar: Make all BD status writes 32-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081216.153517.195238948.davem@davemloft.net>
Date:	Tue, 16 Dec 2008 15:35:17 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	afleming@...escale.com
Cc:	jeff@...zik.org, galak@...nel.crashing.org, netdev@...r.kernel.org,
	Dai.Haruki@...escale.com
Subject: Re: [PATCH v2.6.29 10/14] gianfar: Make all BD status writes 32-bit

From: Andy Fleming <afleming@...escale.com>
Date: Tue, 16 Dec 2008 17:21:03 -0600

> Whenever we want to update the status field in a BD, we usually want to
> update the length field, too.  By combining them into one 32-bit field, we
> reduce the number of stores to memory shared with the controller, and we
> eliminate the need for order-enforcement, as the length and "READY" bit are
> now updated atomically at the same time.
> 
> Signed-off-by: Dai Haruki <Dai.Haruki@...escale.com>
> Signed-off-by: Andy Fleming <afleming@...escale.com>

Applied.

But this seems to point out that all of this descriptor
code needs to be endianness annotated and use endianness
types like __be32
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html