netdev - Re: [PATCH] tcp: make urg+gso work for real this time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081217153015.GA17903@ms2.inr.ac.ru>
Date:	Wed, 17 Dec 2008 18:30:15 +0300
From:	Alexey Kuznetsov <kuznet@....inr.ac.ru>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Petr Tesarik <ptesarik@...e.cz>,
	Ilpo J??rvinen <ilpo.jarvinen@...sinki.fi>,
	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] tcp: make urg+gso work for real this time

Hello!

> Probably, netbsd/openbsd have some another quirk to work this around.
> I do not see how, though.

F.e. this could be totally safe if we do this only in the case
when octet seq+0xFFFF has not yet been sent.

When we send segment with 0xFFFF inside urg_ptr is advanced and so on,
so that receiver has no chances to corrupt stream.

I.e. we set URG and urg_ptr to fake scb->seq + 0xFFFF only when:

	after(scb->seq + 0xFFFF, tp->snd_nxt)

My brains are rusty, so take this critically. :-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html