netdev - Re: net-next: broken IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081217.221719.195850752.davem@davemloft.net>
Date:	Wed, 17 Dec 2008 22:17:19 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	markmc@...hat.com, andi@...stfloor.org, netdev@...r.kernel.org
Subject: Re: net-next: broken IP_PKTINFO

From: Eric Dumazet <dada1@...mosbay.com>
Date: Thu, 18 Dec 2008 06:59:26 +0100

> David Miller a écrit :
> > Eric, we'll need to rever this change I think.
> 
> I am afraid we have to revert it, yes.

Done.

> About ip_cmsg_recv_pktinfo() :
> 
> iif can be found in skb->iif instead of rt->rt_iif, but I am not sure
> about rt_spec_dst : Shouldnt we find it in ip_hdr(skb)->saddr ?
>  
> Do you know if we really need rtable in ip_cmsg_recv_pktinfo() ?

I think we might, as these are routing attributes, which not
necessarily match up with the values found in the SKB.

In fact, I do remember that "specific destination" has a very
exact definition in the routing RFCs and it has to do with the
matched route.

Conversely, in what situations (other than with the reverted patch
applied, hehe) would the route not be attached here?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html