netdev - Re: [PATCH] ppp: fix segfaults introduced by netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 18 Dec 2008 19:40:28 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jchapman@...alix.com
Cc:	netdev@...r.kernel.org, wangchen@...fujitsu.com
Subject: Re: [PATCH] ppp: fix segfaults introduced by netdev_priv changes

From: James Chapman <jchapman@...alix.com>
Date: Thu, 18 Dec 2008 10:28:19 +0000

> David Miller wrote:
> > From: James Chapman <jchapman@...alix.com>
> > Date: Wed, 17 Dec 2008 22:02:16 GMT
> > 
> >> +	} else
> >> +		ppp_unlock(ppp);
> >> +
> >>  	cardmap_set(&all_ppp_units, ppp->file.index, NULL);
> >>  	ppp->file.dead = 1;
> >>  	ppp->owner = NULL;
> > 
> > James, thanks for this fix.  But you'll need to respin this
> > as it conflicts with the IDR changes that are in net-next-2.6
> > (this cardmap_set call isn't there any more, for example).
> 
> The patch is against net-2.6. I assumed it was appropriate for net-2.6
> since we're on rc8 and ppp has been broken since rc6. :) Sorry I didn't
> mention that in the patch.

That part I missed, I thought it was caused by the conversions
we did only in net-next-2.6

I'll apply your original net-2.6 patch, thanks James!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html