netdev - Re: smsc911x unloading crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OFB5E57180.CCA30733-ON80257524.00382ADA-80257524.004340AF@smsc.com>
Date:	Fri, 19 Dec 2008 12:13:31 +0000
From:	Steve.Glendinning@...c.com
To:	dfoley@...us.net
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Ian.Saturley@...c.com
Subject: Re: smsc911x unloading crash

Hi dfoley,

> I am testing out the new smsc911x driver that is in the linux-next tree.
> I get a crash when unloading the module. I've got this patch to 
> fix it. I noticed that the dev_set_drvdata is clobbering the data when
> the driver's ..._remove function calls dev = platform_get_drvdata(pdev);
> I've back ported this to run on 2.6.27, so this patch may or
> may not be needed. Sorry if it's a matter of not having the latest 
version.

This is indeed a bug, thanks for finding it.  Some other drivers use the
device driver_data for storing their mii_bus, but we already store our
net_device there so we shouldn't be setting this here.

> dfoley, even if your patch is correct your email client has severely
> corrupted the patch (changing tab characters into spaces, etc.) so if
> this patch is still needed you'll need to resubmit with your email
> client fixed to not corrupt the patch with formatting changes.

The [broken] patch actually fixes two different bugs, can you split this
into two patches?

The second bug is a typo - It's supposed to look the same as the code
in smsc911x_drv_probe 35 lines later, but it's missing the assignment.

Both Signed-off-by: Steve Glendinning <steve.glendinning@...c.com>

Regards,
--
Steve Glendinning
SMSC GmbH
m: +44 777 933 9124
e: steve.glendinning@...c.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html