netdev - Re: [PATCH 2/6] ucc_geth: Fix TX watchdog timeout handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed82fe3e0812201919o619fd7e7jb87bbec551caa4d@mail.gmail.com>
Date:	Sat, 20 Dec 2008 21:19:23 -0600
From:	"Timur Tabi" <timur@...escale.com>
To:	"Anton Vorontsov" <avorontsov@...mvista.com>
Cc:	"Jeff Garzik" <jgarzik@...ox.com>,
	"David Miller" <davem@...emloft.net>,
	"Li Yang" <leoli@...escale.com>,
	"Andy Fleming" <afleming@...escale.com>, netdev@...r.kernel.org,
	linuxppc-dev@...abs.org
Subject: Re: [PATCH 2/6] ucc_geth: Fix TX watchdog timeout handling

On Thu, Dec 18, 2008 at 12:23 PM, Anton Vorontsov
<avorontsov@...mvista.com> wrote:
> +static int ucc_geth_close(struct net_device *dev);
> +static int ucc_geth_open(struct net_device *dev);

I would prefer that you reorder the functions to eliminate the need
for forward references.

-- 
Timur Tabi
Linux kernel developer at Freescale
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html