lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 22 Dec 2008 19:13:43 +0800
From:	"Li Yang" <leoli@...escale.com>
To:	"Timur Tabi" <timur@...escale.com>
Cc:	"Anton Vorontsov" <avorontsov@...mvista.com>,
	netdev@...r.kernel.org, linuxppc-dev@...abs.org,
	"Andy Fleming" <afleming@...escale.com>,
	"Jeff Garzik" <jgarzik@...ox.com>,
	"David Miller" <davem@...emloft.net>
Subject: Re: [PATCH 6/6] ucc_geth: Remove UGETH_FILTERING dead code

On Sun, Dec 21, 2008 at 11:23 AM, Timur Tabi <timur@...escale.com> wrote:
> On Thu, Dec 18, 2008 at 12:23 PM, Anton Vorontsov
> <avorontsov@...mvista.com> wrote:
>> The code appears to be dead: nobody call these functions, plus build
>> breaks when UGETH_FILTERING is enabled:
>
> I general, I agree with patches like this, but I'd like to hear from
> Leo first why this code was written in the first place before I can
> ack it.

The code was there to test the frame filtering feature which probably
can be used in multicast and VLAN support.  I didn't remove it because
it could be a base for whoever interested to implement a general frame
filtering framework or custom features.  Given the fact that unused
code can easily become broken.  I agree that it can be removed for
now.

Acked-by: Li Yang <leoli@...escale.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists