netdev - Re: [PATCH] ehea: use get_zeroed_page for alignment-sensitive allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18883.1229973288@jerryjeff>
Date:	Mon, 22 Dec 2008 13:14:48 -0600
From:	Doug Maxey <dwm@...tin.ibm.com>
To:	Nathan Lynch <ntl@...ox.com>
cc:	netdev@...r.kernel.org, hannes.hering@...ux.vnet.ibm.com,
	linuxppc-dev@...abs.org, raisch@...ibm.com,
	ossrosch@...ux.vnet.ibm.com, ossthema@...ibm.com,
	osstklei@...ibm.com
Subject: Re: [PATCH] ehea: use get_zeroed_page for alignment-sensitive allocation


On Mon, 22 Dec 2008 12:42:11 CST, Nathan Lynch wrote:
> With slub debug enabled, I see the following errors and crash with
> 2.6.28-rc9:
> 
> IBM eHEA ethernet device driver (Release EHEA_0095)
> ehea: Error in ehea_h_register_rpage_mr: not on pageboundary
> ehea: Error in ehea_reg_mr_section: register_rpage_mr failed
> ehea: Error in ehea_reg_kernel_mr: registering mr failed
> ehea: Error in ehea_setup_ports: creating MR failed
> ehea 23c00100.lhea: setup_ports failed
> Unable to handle kernel paging request for data at address 0x6b6b6b6b6b6bbdcb
> Faulting instruction address: 0xd000000000064a24
> cpu 0x0: Vector: 300 (Data Access) at [c0000000740e7190]
>     pc: d000000000064a24: .ehea_update_firmware_handles+0x84/0x47c [ehea]
>     lr: d00000000006df34: .ehea_probe_adapter+0x35c/0x39c [ehea]
>     sp: c0000000740e7410
>    msr: 8000000000009032
>    dar: 6b6b6b6b6b6bbdcb
>  dsisr: 40000000
>   current = 0xc000000074233780
>   paca    = 0xc0000000008a3300
>     pid   = 2046, comm = modprobe
> enter ? for help
> [c0000000740e74f0] d00000000006df34 .ehea_probe_adapter+0x35c/0x39c [ehea]
> [c0000000740e75a0] c00000000041d5a4 .of_platform_device_probe+0x78/0xb0
> [c0000000740e7630] c0000000002d8b38 .driver_probe_device+0x13c/0x200
> [c0000000740e76c0] c0000000002d8c90 .__driver_attach+0x94/0xd8
> [c0000000740e7750] c0000000002d7d64 .bus_for_each_dev+0x80/0xd8
> [c0000000740e7800] c0000000002d889c .driver_attach+0x28/0x40
> [c0000000740e7880] c0000000002d8340 .bus_add_driver+0xd4/0x284
> [c0000000740e7920] c0000000002d90a0 .driver_register+0xc4/0x198
> [c0000000740e79d0] c00000000041d45c .of_register_driver+0x4c/0x60
> [c0000000740e7a50] c000000000020ef8 .ibmebus_register_driver+0x30/0x4c
> [c0000000740e7ae0] d00000000006e108 .ehea_module_init+0x194/0x208c [ehea]
> [c0000000740e7b90] c000000000009028 .do_one_initcall+0x90/0x1ac
> [c0000000740e7d90] c00000000008619c .sys_init_module+0xc4/0x200
> [c0000000740e7e30] c0000000000084ac syscall_exit+0x0/0x40
> 
> (When slub debug is disabled it works fine.)
> 
> PAGE_SIZE allocations via slab are not guaranteed to be page-aligned;
> use get_zeroed_page for the 'pt' buffer (I don't really know what this
> is, only that it is passed to firmware and that the first error
> message complains about its alignment).  This allows the system to
> boot.
> 
> Signed-off-by: Nathan Lynch <ntl@...ox.com>
> ---
>  drivers/net/ehea/ehea_qmr.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> By the way, there are several other kzalloc(PAGE_SIZE) call sites in
> this driver; are they also making assumptions about alignment?

meh. I would say yes, pretty much everything is expecting a page alignment 
(4K at least).  

++doug


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html