lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 24 Dec 2008 22:17:15 -0800
From:	Junio C Hamano <>
To:	Krzysztof Halasa <>
Cc:	Linus Torvalds <>,
	Harvey Harrison <>,
	Håkon Løvdal <>,
	Hannes Eder <>,,,
Subject: Re: [PATCH 02/27] drivers/net: fix sparse warnings: make do-while a
 compound statement

Krzysztof Halasa <> writes:

> Linus Torvalds <> writes:
> ...
>> Another example of "common vs non-common" is this:
>> 	if (0 <= x)
>> 		do something..
>> is something that crazy people do (sadly, one of the crazy people taught 
>> the git maintainer C programming, so now even sane people do it). It's 
>> crazy because it's uncommon, which means that most people have to think 
>> about it A LOT MORE than about
>> 	if (x >= 0)
>> 		do something..
> No. It's crazy not because it's uncommon, but because this is how we
> have been taught in school.
> I don't know reasons for "0 >= x" but I know one for
> 	if (0 == x)
> 		do something..
> It's because people sometimes write "=" instead of "==" and "0 = x"
> doesn't make sense to gcc.

It does not have anything to do with the assignment confusion.

It is "textual order should reflect actual order" (aka "have number line
in your head when you write your comparison conditional"):

Even if it may make logical sense, I would not suggest using it when other
people are not familiar with the convention, though.

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists