lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 25 Dec 2008 18:18:48 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	yevgenyp@...lanox.co.il
Cc:	jeff@...zik.org, rdreier@...co.com, netdev@...r.kernel.org,
	general@...ts.openfabrics.org
Subject: Re: [PATCH 4/9] mlx4_en: Verify number of RX rings doesn't exceed
 MAX_RX_RINGS

From: Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Date: Mon, 22 Dec 2008 12:00:49 +0200

> Required in cases were dev->caps.num_comp_vectors > MAX_RX_RINGS.
> For current values this would happen on machines that have more
> then 16 cores.
> 
> Signed-off-by: Yevgeny Petrilin <yevgenyp@...lanox.co.il>

This patch does not apply to the tree.

In fact, there is no reference at all to num_comp_vectors
in the mlx4_en driver at all.  The code there currently reads:

		if (!mdev->profile.prof[i].rx_ring_num) {
			mdev->profile.prof[i].rx_ring_num = 1;
			mlx4_info(mdev, "Defaulting to %d rx rings for port:%d\n",
				  1, i);

So there is some other patch applied to your copy of the driver
already that adds all of that num_comp_vectors stuff.  It isn't
in the upstream sources, and it certainly isn't in the networking
development GIT tree(s), that is for sure.

Please, please (did I say please?), please be more careful
in the future and don't send patches that do not apply properly
to the tree.  This wastes a lot of my time and discourages my
handling your patches efficiently in the future.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists