netdev - Re: [PATCH 11/11] benet: Kconfig, MAINTAINETS, drivers/net Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081227.182344.188988811.davem@davemloft.net>
Date:	Sat, 27 Dec 2008 18:23:44 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	subbus@...verengines.com
Cc:	sathyap@...verengines.com, netdev@...r.kernel.org,
	jgarzik@...ox.com, romieu@...zoreil.com, kaber@...sh.net
Subject: Re: [PATCH 11/11] benet: Kconfig, MAINTAINETS, drivers/net Makefile

From: "Subbu Seetharaman" <subbus@...verengines.com>
Date: Sat, 27 Dec 2008 07:41:51 -0800

> Do you still have objection to the use of the the macros to 
> calculate the offsets and shifts with the help of the pseudo 
> structure ratger than defining constants ?

I objected to the capitalized structure names et al.

You should make your driver more match the coding and
naming style used in the rest of the kernel.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html