netdev - Re: 2.6.28-git1 build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49587FDD.5000504@cn.fujitsu.com>
Date:	Mon, 29 Dec 2008 15:44:29 +0800
From:	Wang Chen <wangchen@...fujitsu.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
CC:	Roland Dreier <rdreier@...co.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	netdev@...r.kernel.org, sean.hefty@...el.com,
	Aleksey Senin <alekseys@...taire.com>
Subject: Re: 2.6.28-git1 build failure

Randy Dunlap said the following on 2008-12-29 12:36:
> drivers/built-in.o: In function `addr_resolve_remote':
> addr.c:(.text+0x12fe75): undefined reference to `ip6_route_output'
> drivers/built-in.o: In function `rdma_translate_ip':
> (.text+0x1301a7): undefined reference to `ipv6_chk_addr'
> drivers/built-in.o: In function `rdma_resolve_ip':
> (.text+0x1303a9): undefined reference to `ipv6_chk_addr'
> drivers/built-in.o: In function `rdma_resolve_ip':
> (.text+0x13051b): undefined reference to `ip6_route_output'
> 
> when CONFIG_IPV6=n.
> 

Aleksey added IPv6 function to it but not change the Kconfig file.
The following patch will temporarily fix this build failure.
But IMHO separating the IPv4/IPv6 parts or using #ifdef would be better.

Signed-off-by: Wang Chen <wangchen@...fujitsu.com>
---
diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
index a5dc78a..9535e13 100644
--- a/drivers/infiniband/Kconfig
+++ b/drivers/infiniband/Kconfig
@@ -36,7 +36,7 @@ config INFINIBAND_USER_MEM
 
 config INFINIBAND_ADDR_TRANS
 	bool
-	depends on INET
+	depends on INET && IPV6
 	default y
 
 source "drivers/infiniband/hw/mthca/Kconfig"

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html