netdev - Re: [PATCH] EtherExpress16: fix printing timed out status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081229.184244.198741009.davem@davemloft.net>
Date:	Mon, 29 Dec 2008 18:42:44 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	roel.kluin@...il.com
Cc:	philb@....org, netdev@...r.kernel.org
Subject: Re: [PATCH] EtherExpress16: fix printing timed out status

From: Roel Kluin <roel.kluin@...il.com>
Date: Sun, 28 Dec 2008 22:18:01 +0100

> in drivers/net/eexpress.c:558, function unstick_cu()
> 
> while (!SCB_complete(rsst=scb_status(dev))) {
> 	...
> 	if (...)
> 		printk(KERN_WARNING "%s: Reset timed out status %04x, retrying...\n",
>                                                        dev->name,rsst);
> }
> 
> but this will become 
> 
> while (!((rsst = scb_status(dev) & 0x8000) != 0) ...
> 
> because of the macro:
> 
> #define SCB_complete(s) ((s&0x8000)!=0)
> 
> so rsst can only become either 0x8000 or 0, but in the latter case the loop ends,
> I think the wrong timed out status is printed. This also cleans up similar macros.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html