netdev - Re: [PATCH] netns: foreach_netdev_safe is insufficient in default_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081229.182159.234047580.davem@davemloft.net>
Date:	Mon, 29 Dec 2008 18:21:59 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] netns: foreach_netdev_safe is insufficient in
 default_device_exit

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Sun, 28 Dec 2008 00:10:35 -0800

> During network namespace teardown we either move or delete
> all of the network devices associated with a network namespace.
> In the case of veth devices deleting one will also delete it's
> pair device.  If both devices are in the same network namespace
> then for_each_netdev_safe is insufficient as next may point
> to the second veth device we have deleted.
> 
> To avoid problems I do what we do in __rtnl_kill_links and
> restart the scan of the device list, after we have deleted
> a device.
> 
> Currently dev_change_netnamespace does not appear to suffer from
> this problem, but wireless devices are also paired and likely
> should be moved between network namespaces together.  So I have
> errored on the side of caution and restart the scan of the network
> devices in that case as well.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@...stanetworks.com>

Looks good, applied.

Thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html