netdev - Re: Re: [PATCH 9/9 V2] mlx4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Dec 2008 18:54:58 +0200
From:	Yevgeny Petrilin <yevgenyp@...lanox.co.il>
To:	David Miller <davem@...emloft.net>
CC:	jeff@...zik.org, rdreier@...co.com, netdev@...r.kernel.org
Subject: Re: Re: [PATCH 9/9 V2] mlx4_en: Multiqueue support

David Miller wrote:
> You are not supposed to provide a driver private function
> to hash the traffic.
> 
> The generic code already hashes traffic for you, and whatever
> it doesn't handle currently will be handled in the future.
> The generic code is where gaps should be filled in.
> 
> The override function pointer is only for wireless which has
> special needs in queue selection that have nothing to do with
> flow seperation.
> 

The generic hash function (simple_tx_hash) doesn't consider Vlan priority when making the hash.
When working in Per Priority Pause mode, packets with different Vlan priority should be sent from
a different transmit queue. How can we ensure this without using private hashing function?

Thank you,
Yevgeny.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html