netdev - Re: [BUG] icmpv6fuzz creates bad paging request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090102090515.GA25796@gondor.apana.org.au>
Date:	Fri, 2 Jan 2009 20:05:15 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
Cc:	Eric Sesterhenn <snakebyte@....de>,
	Netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>, yoshfuji@...ux-ipv6.org,
	Yang Hongyang <yanghy@...fujitsu.com>
Subject: Re: [BUG] icmpv6fuzz creates bad paging request

On Fri, Jan 02, 2009 at 08:53:18AM +0000, Ilpo Järvinen wrote:
> 
> Can you try the patch below.

You beat me to it :)

> I wonder btw what's the correct policy wrt. those optval == NULL checks 
> that's visible in the patch' context (IPV6_PKTINFO is the only one which
> is doing that while many there fetch to sizeof(struct something)).

copy_from_user will catch bogus pointers so no extra checks are
necessary.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html