netdev - Re: ixgbe select_queue broken in 2.6.28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090102.001933.70654029.davem@davemloft.net>
Date:	Fri, 02 Jan 2009 00:19:33 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	jeffrey.t.kirsher@...el.com, donald.c.skidmore@...el.com,
	netdev@...r.kernel.org
Subject: Re: ixgbe select_queue broken in 2.6.28

From: Stephen Hemminger <shemminger@...tta.com>
Date: Thu, 1 Jan 2009 22:54:56 -0800

> The ixgbe driver in 2.6.28 modifies select_queue. This is bad
> in a couple of ways:
>   1) select_queue is now in net_device_ops so the driver won't build
>      unless CONFIG_COMPAT_NET_DEV_OPS is defined
>   2) it is changing data that is shared and supposed to be immutable.
> 
> Looks like a some of the DCB stuff forgot to look at net_device_ops

Drivers shouldn't be overriding the ->select_queue() method unless
there is a very specific reason to do so.  Ethernet drivers will not
have such a reason.

This is a very bad trend and I think I'm going to need to simply
remove the ->select_queue() method to stop the bleeding.

If people keep overriding this method in their drivers, then when we
move to more sophisticated methods of computing the hash we will have
to hit all of these override spots which makes the generic queue
selection function pointless.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html