netdev - Re: [PATCH] Fix up truesize after pskb_expand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090104184136.GY496@one.firstfloor.org>
Date:	Sun, 4 Jan 2009 19:41:36 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Andi Kleen <andi@...stfloor.org>, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, linville@...driver.com,
	davem <davem@...emloft.net>
Subject: Re: [PATCH] Fix up truesize after pskb_expand_head() in wireless stack

On Sun, Jan 04, 2009 at 06:33:08PM +0100, Johannes Berg wrote:
> On Sun, 2009-01-04 at 18:43 +0100, Andi Kleen wrote:
> 
> > > we need to do is figure out is why the skb has a wrong truesize.
> > 
> > Because it was expanded without truesize being adjusted (see my
> > original mail) 
> 
> So why is this not making trouble with all the other users?

I think most adjustments are too small to be noticed. Typically
they are just for a few bytes in the header. truesize
is already larger, so it can tolerate some slag.

I also only see it occasionally (maybe 5-10 times/day) when
the wireless stack appends a lot of data.

My proposal would be to include this patch for 2.6.28/2.6.29
and investigate fixing pskb_expand_head for 2.6.30.

-Andi

-- 
ak@...ux.intel.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html