netdev - Re: [BUG] icmpv6fuzz creates bad paging request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090104.172821.105803003.davem@davemloft.net>
Date:	Sun, 04 Jan 2009 17:28:21 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	ilpo.jarvinen@...sinki.fi, snakebyte@....de,
	netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org,
	yanghy@...fujitsu.com
Subject: Re: [BUG] icmpv6fuzz creates bad paging request

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Fri, 2 Jan 2009 20:05:15 +1100

> On Fri, Jan 02, 2009 at 08:53:18AM +0000, Ilpo Järvinen wrote:
> > 
> > Can you try the patch below.
> 
> You beat me to it :)

I applied Ilpo's version, because he won :-)  Thanks everyone.

> > I wonder btw what's the correct policy wrt. those optval == NULL checks 
> > that's visible in the patch' context (IPV6_PKTINFO is the only one which
> > is doing that while many there fetch to sizeof(struct something)).
> 
> copy_from_user will catch bogus pointers so no extra checks are
> necessary.

Right.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html