[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090105.160535.24967514.davem@davemloft.net>
Date: Mon, 05 Jan 2009 16:05:35 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: sfr@...b.auug.org.au
Cc: netdev@...r.kernel.org, linuxppc-dev@...abs.org, raisch@...ibm.com,
themann@...ibm.com, tklein@...ibm.com
Subject: Re: [PATCH] net/ehea: bitops work on unsigned longs
From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Tue, 6 Jan 2009 10:59:51 +1100
> Hi Dave,
>
> On Tue, 30 Dec 2008 21:51:56 -0800 (PST) David Miller <davem@...emloft.net> wrote:
> >
> > From: Stephen Rothwell <sfr@...b.auug.org.au>
> > Date: Wed, 31 Dec 2008 14:18:53 +1100
> >
> > > These changes will avoid several warnings when we change u64 to unsigned
> > > long long.
> > >
> > > Also, ehea_driver_flags is only used in ehca_main.c
> > >
> > > Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
> > > ---
> >
> > And also rejected, just like the previous two.
> >
> > This is so much worse than the problems we had with
> > printing u64's and it's being done as a result to
> > the "fix" for that.
>
> How is this worse than anything? The only thing wrong with this patch is
> the commit message ... Lets try this (if this doesn't address your
> problems, then assume I am too dense for your original explanation):
Aha, yes the commit message fooled me :-) New patch is fine and
I'll toss this into net-2.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists