netdev - Re: ixgbe select_queue broken in 2.6.28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1LKBaB-0007kB-7f@gondolin.me.apana.org.au>
Date:	Wed, 07 Jan 2009 00:02:55 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	peter.p.waskiewicz.jr@...el.com (Waskiewicz Jr, Peter P)
Cc:	davem@...emloft.net, shemminger@...tta.com,
	jeffrey.t.kirsher@...el.com, donald.c.skidmore@...el.com,
	netdev@...r.kernel.org
Subject: Re: ixgbe select_queue broken in 2.6.28

Waskiewicz Jr, Peter P <peter.p.waskiewicz.jr@...el.com> wrote:
> 
> I understand why you want to remove this, but at the same time it is 
> something that is useful if we don't abuse it.  I know for a fact this 
> function pointer is very useful for routing performance setups, where 
> binding a Tx queue to the CPU is very useful.  Jesse actually did the work 
> on testing and getting good results with this.

Sure.  But that is not driver-specific.  The only reason to do
an override is if the hash needs to be driver-specific.  So far
the only reasons that have been given are deficiencies in the
current hash, rather than a genuine need by the driver.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html